add simple tests #15
Open
add simple tests #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voku
changed the title
|
There are too many changes within this one request, would it be possible to break this up into 3 separate requests.
I love the idea of adding testing to this class so I am thrilled to get these changes merged and of course get a new version released. My concern is making it clear what happened. Please let me know if this is achievable. |
Open
Open
|
Sorry, I can't keep such phpdocs untouched. ;-) Yes I can revert the code changes and keep the test classes. |
Its no problem at all, I am really glad to see some progress on this package! Provided you can make these changes, I will get this pushed through as soon as I can finish reading the reviews. |
voku
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is