Support for btn input addons #25
Conversation
| @@ -43,7 +43,11 @@ def field_in_group(field, prefix, suffix) | |||
| end | |||
|
|
|||
| def input_addon(addon) | |||
| content_tag :span, addon, class: 'input-group-addon' if addon | |||
| if addon && addon.include?('class="btn') | |||
There was a problem hiding this comment.
Don't really like having to do that kind of matching, but it was the only I found getting input-group-btn to work without providing extra options. Perhaps its just better to provide an options button: true or something like that. Any suggestions?
There was a problem hiding this comment.
Finally I got time to look at this.
I cannot think of a much better solution than what you suggest.
The Bootstrap documentation says:
Buttons in input groups are a bit different and require one extra level of nesting.
Instead of .input-group-addon, you'll need to use .input-group-btn to wrap the buttons.
My understanding is that .input-group-btn should be used only if the content is exactly a button.
So one solution would be to scan the string for a regex like %{^<button.+>.+</button>$}.
However, as you point out, the content might be a different DOM element looking like a button, for instance
<input type="submit" class="btn btn-default">In any case, all I can think of is a regex-matching of addon, similar to what you suggest…
There was a problem hiding this comment.
Because I don't have a clear opinion about this yet, I'll mark this PR as "version 1.2"!
| @@ -56,6 +56,11 @@ def self.field_helpers_to_test | |||
| it { expect(form).to match %r{<div class="input-group"><.+?><span class="input-group-addon">Jr</span></div>}m } | |||
| end | |||
|
|
|||
| context 'given a suffix option that is a button, prints the correct addon wrapper class' do | |||
| let(:options) { {suffix: content_tag(:button, 'hey', class: 'btn btn-default')} } | |||
There was a problem hiding this comment.
Since the objects that can be used as prefixes or suffixes are limited, I wouldn't want to expose the generic content_tag as the way to use prefixes or suffixes that are not plain text.
For instance, right now you can write
<%= f.text_field :name, prefix: 'ok' %>The next nice step would be
<%= f.text_field :name, prefix: icon(:ok) $>
which I expect not to be working now, not being HTML-safe (I might be wrong, I didn't check).
So for the input group button, I'd like the syntax to be
<%= f.text_field :name, suffix: button_to('Go', action: 'submit') %>which would be easier to write (and less prone to errors) than the full content_tag. What do you think?
There was a problem hiding this comment.
Trying this PR locally, I found a couple of things:
- The
button_tohelper I wrote is incomplete. It only works in the form where the second argument is a route, but it does not work if the second argument is options. This is similar to what happened withfields_for. So I need to fix that separately - Even though the following code works, the
button_tohelper from ActionView adds an extra<div>around the<input type="button">field which makes the suffix display in a weird way:
<%= f.text_field :email, suffix: button_to('Go', signin_path) %>With the current master displays as:
After the current PR would display as:
Which a little different from the desired behavior:
|
Looking at the code, I realize that we might actually want a simple <%= button 'Go', context: :success %>would simply transform into <button class="btn btn-success" type="button">Go</button>Initially I thought we could just use Once the |
|
Also, ActionView already provides a similar helper called |
|
That is the exact thing I've done in #15 in
|
|
Yes! Taking a look at that now. |
|
@claudiofullscreen status? let me know if I can do anything |
Adds support for http://getbootstrap.com/components/#input-groups-buttons