binary intrinsic declarations

[sn6uv]

Fixes binary intrinsic (e.g. llvm.maxnum) IR generation.

Note: I haven't tested e.g. llvm.convert.from.fp16.

[coveralls]

Coverage increased (+0.02%) to 93.457% when pulling 4a47ddc on sn6uv:master into 8a324e1 on numba:master.

[codecov-io]

Current coverage is 91.93% (diff: 100%)

Merging #205 into master will increase coverage by 0.01%

@@             master       #205   diff @@
==========================================
  Files            32         32          
  Lines          4574       4585    +11   
  Methods           0          0          
  Messages          0          0          
  Branches        319        322     +3   
==========================================
+ Hits           4204       4215    +11   
  Misses          300        300          
  Partials         70         70          

Powered by Codecov. Last update 8a324e1...4a47ddc

[sn6uv]

Any word on this? Is anyone aware of a workaround to use in the meantime?

[pitrou]

Oops, sorry. I hadn't noticed this PR.
The workaround is simply to construct the Function object yourself.

[pitrou]

llvm.pow is already handled here (note you can also pass the function type fnty explicitly).

[sn6uv]

I understand better what's going on now and my patch isn't quite right. The solution for me is just to avoid the declare_intrinsic function.

However, there's still something to fix here I feel:

fnty = ir.FunctionType(double_type, [double_type, double_type])
mod.declare_intrinsic('llvm.pow', [double_type, double_type], fnty)

crashes because the name mangling isn't correct:

    mod = compile_ir(engine, llvm_ir)
  File "/home/angus/Mathics/mathics/builtin/compile/compile.py", line 38, in compile_ir
    mod.verify()
  File "/home/angus/llvmlite/llvmlite/binding/module.py", line 95, in verify
    raise RuntimeError(str(outmsg))
RuntimeError: Intrinsic name not mangled correctly for type arguments! Should be: llvm.pow.f64
double (double, double)* @llvm.pow.f64.f64

Or is the intended way to call function just exactly what's needed to match the llvm intrinsic full name? I.e.:

mod.declare_intrinsic('llvm.pow', [double_type], fnty)

In this case I can just update the docstring for declare_intrinsic.

[pitrou]

is the intended way to call function just exactly what's needed to match the llvm intrinsic full name?

Right. For llvm.pow, it seems fnty needn't even be passed.

[sn6uv]

Okay, thanks @pitrou. I understand the behaviour of declare_intrinsic but I still find it slightly counter-intuitive. Regardless, I'm closing this PR.