Mock assembly for testing and its program generator #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esc
reviewed
Mar 25, 2023
numba_rvsdg/mock_asm.py
Outdated
|
|
||
| def test_double_exchange_loop(): | ||
| asm = """ | ||
| print Start |
There was a problem hiding this comment.
I would recommend using the textwrap.dedent function here such that the asm is indented like the Python code that defines it.
There was a problem hiding this comment.
indentation shouldn't matter. i probably could have indent the asm to the same level to the python source
|
I'll be focusing on numba release this week. If you want to make changes to this PR or refactor it, feel free and don't wait for me. |
|
@sklam thank you! I move the module to the tests directory too so that it can be picked up by our CI! Thank you for the patch! |
|
I had to split the tests and definition of the mock_asm module, perhaps the imports could be fixed up. |
As title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.