Add method for pip dependencies #25
Conversation
Amend pip_dependency to make it a list, and added that functionality to the install command to allow for a list to be processed.
Change return from NotImplementedError to empty list
|
@KevinCawley looks good, the tests are passing too so that's good and I like the way they are optional! Is there anything that can be done to add testing this feature to either the system or the unit tests of this (texasbbq) package? |
|
I'm not sure how I could add any additional testing to CircleCI. I could import some other tests from the numba_integration_testing and add them temporarily to it in order for those to run if you think that's a good idea. One thing I did not is that there hasn't been a new release of Texasbbq in almost two years, so when I downloaded this to do some local testing it didn't have functions like |
My suggestion would be to add a fake pip dependency or two to the
Yes, I only ever made an initial release to secure the package name on PyPi. Since then, the integration testing has been |
|
That sounds good. I can work on the umap later tonight and tomorrow. |
|
Looks like I won't be able to make another commit until Sunday, sorry. |
|
@KevinCawley no worries at all sir, no pressure. If you run out of time, just let me know and I'll take over. |
|
@esc I have put in a few hours trying to figure out how to test for the packages using the unit_test file and have been unable to. I think I will be passing the torch to you for the testing part unfortunately. Sorry. |
|
@esc I realized that I can simply try to import the pip modules in a test function and see if I get an error. I wasn't sure how I would be able to make these tests, I didn't realize it was that simple. I will try to have this done by today. As a question, should I catch the ModuleNotFoundError or just let pytest deal with it? |
Oh, that'S great news! Not sure, about the error, maybe let pytest just deal with it?! |
|
@esc New methodology, tests passed. |
|
@KevinCawley awesome, thank you! I'll merge this now. If you want, please do open a tiny PR for the numba-integration-testing repo to upgrade the |
|
@esc New release time? 😄 |
|
@KevinCawley indeed, but I need to delay that by about one week, we are getting ready to tag Numba an llvmlite next week and there are still quite a number of tasks left. We will tag those next Thursday and so I'll have plenty of time 🤞 to tag and release texasbbq on Friday. I just noticed, it has neither a set of "maintainers notes on how to cut a release" nor a changelog (this will be the first meaningful release, besides squatting the project on PyPi). So I'd like to add those and not need to rush it out the door. Thank you in advance for your understanding and patience. 🙏 |
|
Just checking in on the new tag, but no rush. |
|
@KevinCawley still in the release period, so sorry. Soon, I hope!! |
|
Just another check-in, more out of curiosity than anything. I can see how the pip dependencies aren't a big change though. |
Oh, yes, thank you for the ping, I had completely forgotten about this 🤷 |
|
@KevinCawley can you review #27 -- I'll tag and PyPi upload then |
|
@KevinCawley https://pypi.org/project/texasbbq/0.2.1/ -- had some issues with RST on PyPi so I reduced the amount of metadata on PyPi. |
This is an addition to allow pip dependencies to be installed easier, so that a custom install command isn't needed to be made.