Feature migrate to capacitor 3 #1358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change button color to match design
remove unused imports, init logic.
scss-linting
method from lodash to compare objects
bluetooth plugin
to wrap scanForBluetooth call
remove unused comments
remove unused variable
methods to src/utils/url.ts
instead of Plugins.Storage
use preferenceManager instead of Plugins.Storage
ruizehung
reviewed
Mar 15, 2022
Contributor
There was a problem hiding this comment.
Overall, very nice work @sultanmyrza ! The changes seem reasonable to me.
- I think we should use
TranslocoServiceand add Mandarin translation for go-pro feature related text display in the app. e.g. The text ingo-pro-media-list-on-camera.component.html,go-pro.page.htmlshould have their correspoding Mandarin translation. I can help you with this. Let me know : ) - For the merge conflicts, I've addressed the profile page one in a comment below. The other 2 conflicts should be easy to resolve. I was able to merge this PR into the latest develop locally, build and run the app successfully.
...gs/go-pro/go-pro-media-item-detail-on-camera/go-pro-media-item-detail-on-camera.component.ts
Show resolved
Hide resolved
ruizehung
reviewed
Mar 16, 2022
Contributor
ruizehung
left a comment
ruizehung
left a comment
There was a problem hiding this comment.
LGTM. @shc261392 do you have any comments or suggestions?
shc261392
approved these changes
Mar 28, 2022
shc261392
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito
┆Created By: Tammy Yang