Skip to content

Build bump to 0.54.2 #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shc261392 merged 4 commits into from
Apr 22, 2022
Merged

Build bump to 0.54.2 #1540

shc261392 merged 4 commits into from
Apr 22, 2022

Conversation

@sultanmyrza
Copy link
Contributor

@sultanmyrza sultanmyrza commented Apr 22, 2022

No description provided.

shc261392
shc261392 approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@shc261392 shc261392 merged commit f765b10 into develop Apr 22, 2022
@shc261392
Copy link
Contributor

shc261392 commented Apr 22, 2022

Discussion for preview-video plugin
https://dt42-numbers.slack.com/archives/C0323488MEJ/p1650612388174209
https://dt42-numbers.slack.com/archives/C0323488MEJ/p1650614603596759

[capture-lite]
We can choose from either

  1. Disable the component test in tsconfig.spec.json by adding "exclude": ["src/<path-to-the-file>/go-pro-media-viewer-with-native-player.component.ts"]
  2. Inside GoProMediaViewerWithNativePlayerComponent, check platform before calling any functions from preview-video plugin. If it is web, don’t call any unimplemented functions from preview-video.

[preview-video]
The previous change can be reverted.

@sultanmyrza sultanmyrza deleted the build-bump-to-0.54.2 branch June 11, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shc261392 shc261392 shc261392 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sultanmyrza @shc261392