Rebuild Capture - Step D2 (Auto-uploading) #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick implementation but might be suboptimal depends on how we want to design the data abstraction. Signed-off-by: James Chien <shc261392@gmail.com>
DiaAssetRepository no longer serves as a local repository, so add instead of createAsset$ is removed to prevent confusion since it does not really store any data now. The notification functionality is removed by request. Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
Signed-off-by: James Chien <shc261392@gmail.com>
shc261392
changed the title
seanwu1105
approved these changes
Jan 15, 2021
src/app/features/home/capture-tab/capture-details/capture-details.page.html
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diaBackendAssetIdandisCollectedproperty in Proof.