Skip to content

Display stroked status style if the asset is not owned by the user. #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2021
Merged

Display stroked status style if the asset is not owned by the user. #526

merged 1 commit into from
Feb 3, 2021

Conversation

@seanwu1105
Copy link
Contributor

@seanwu1105 seanwu1105 commented Feb 2, 2021

According to the slack discussion:

@tammyyang

  • asset 是我的 => 實心
  • asset 是別人的 => 空心

如果確定就是這個行為的話，就定下來
QA 以後就用這個標準測

@wcchung
這個標準我覺得也 OK，那目前就是接受者退回的 icon 需要改成空心

@seanwu1105 seanwu1105 added this to the beta 11 milestone Feb 2, 2021
@seanwu1105 seanwu1105 requested a review from shc261392 February 2, 2021 07:25
@seanwu1105 seanwu1105 self-assigned this Feb 2, 2021
@seanwu1105 seanwu1105 merged commit f65b5cd into develop Feb 3, 2021
@seanwu1105 seanwu1105 deleted the fix-format-activity-status branch February 3, 2021 03:00
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shc261392 shc261392 shc261392 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seanwu1105 seanwu1105

Labels

None yet

Projects

None yet

Milestone

beta 11

Development

Successfully merging this pull request may close these issues.

3 participants

@seanwu1105 @shc261392