Camera rebrand feature flash #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafu
reviewed
Jul 19, 2022
| async enableTorch(enable: boolean): Promise<void> { | ||
| if (this.isNativePlatform) { | ||
| return await PreviewCamera.enableTorch({ enable }); | ||
| } |
There was a problem hiding this comment.
@sultanmyrza Should we handle the "else" case?
There was a problem hiding this comment.
@bafu we do not support web at this point so I don't think we need else block.
There was a problem hiding this comment.
The return type is Promise, and the function will return implicitly in the "else" case.
In camera.enableTorch (L183), it just awaits the service.enableTorch, so functionality-wise it should work. It might increase future readability for the other collaborators to indicate the return value in the "else" case.
bafu
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.