Feat upgrade capacitor from 3 to 4 try 1 #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bafu
requested changes
Nov 20, 2022
| @@ -20,10 +20,47 @@ export class MockAppPlugin implements AppPlugin { | |||
| throw new Error('Method not implemented.'); | |||
| } | |||
|
|
|||
| // addListener( | |||
There was a problem hiding this comment.
@sultanmyrza Suggest adding a comment about why commenting out and keep these codes so that we can catch up on the reason in the future quickly.
sultanmyrza
commented
Nov 23, 2022
| @@ -20,35 +20,6 @@ export class MockAppPlugin implements AppPlugin { | |||
| throw new Error('Method not implemented.'); | |||
| } | |||
|
|
|||
| // addListener( | |||
There was a problem hiding this comment.
In the previous commit, I forgot to remove this commented code. It's safe to remove these lines.
bafu
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
┆Issue is synchronized with this Asana task by Unito