UI series #606
Merged
UI series #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanwu1105
suggested changes
Apr 1, 2021
seanwu1105
suggested changes
Apr 1, 2021
src/app/features/home/post-capture-tab/post-capture-tab.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/home/post-capture-tab/post-capture-tab.component.scss
Outdated
Show resolved
Hide resolved
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Show resolved
Hide resolved
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
seanwu1105
suggested changes
Apr 1, 2021
src/app/features/home/post-capture-tab/post-capture-tab.component.ts
Outdated
Show resolved
Hide resolved
| id: string | null | undefined; | ||
| cover: string | null | undefined; | ||
| collectionGeneral = [ | ||
| { img: null }, |
There was a problem hiding this comment.
Replace null with undefined if possible.
| @@ -0,0 +1,52 @@ | |||
| // tslint:disable: no-magic-numbers | |||
There was a problem hiding this comment.
Why mark this "unresolved" converation resolved? Still, you did not remove the deprecated comments for TSLint.
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
|
@CS6 Remember to pass all checks before requesting for review. Thanks. |
seanwu1105
suggested changes
Apr 1, 2021
| @@ -0,0 +1,52 @@ | |||
| // tslint:disable: no-magic-numbers | |||
There was a problem hiding this comment.
Why mark this "unresolved" converation resolved? Still, you did not remove the deprecated comments for TSLint.
src/app/shared/services/dia-backend/series/dia-backend-series-repository.service.ts
Outdated
Show resolved
Hide resolved
seanwu1105
suggested changes
Apr 1, 2021
src/app/features/home/post-capture-tab/post-capture-tab.component.html
Outdated
Show resolved
Hide resolved
This was referenced Oct 1, 2021
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
關於頁面 3 的 C 部分 (按照 asset 是否擁有的狀況顯示 asset 或者底圖)，這個部分等 QA 測完第一部分後，會請 @seanwu1105 接手
換句話說，QA 測是你的 release 會期待
* 可以從 photo view 切換到 series view 再切回來，都不會有問題，可以正確看到 買過的 series
* 點選 series 封面會進入 collection view
* 在 collection view 底下，再點選上方的 series view icon 會回到 series view
此部分之前已改為開新頁面顯示
* 在 collection view 底下，可以看到正確的 series 封面與留空的九宮格照片，但裡面目前並無法正確顯示照片
* 在 collection view 滑動的時候，封面照片會跟著滑動
New series 封面樣式
