Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support large media asset. #683

Merged
merged 2 commits into from
May 13, 2021
Merged

Support large media asset. #683

merged 2 commits into from
May 13, 2021

Conversation

seanwu1105
Copy link
Contributor

  • Use capacitor-blob-writer to write large file into native filesystem.
  • Use HttpClient to read large file into Angular.
  • Avoid using Capacitor.Filesystem.readFile and Capacitor.Filesystem.writeFile if possible.
  • Create video thumbnail with video URL instead of base64 string.

Tested on Exodus 1 with 20 seconds video recording.

- Use `capacitor-blob-writer` to write large file into native filesystem.
- Use `HttpClient` to read large file into Angular.
- Avoid using `Capacitor.Filesystem.readFile` and
  `Capacitor.Filesystem.writeFile` if possible.
@seanwu1105 seanwu1105 added this to the RC1 milestone May 12, 2021
@seanwu1105 seanwu1105 requested a review from shc261392 May 12, 2021 09:38
@seanwu1105 seanwu1105 self-assigned this May 12, 2021
@seanwu1105 seanwu1105 requested a review from bafu May 12, 2021 09:39
Copy link
Contributor

@shc261392 shc261392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS

@bafu
Copy link
Contributor

bafu commented May 12, 2021

The PR seems to have a side effect: user will fail to restore the videos

bafu 6:52 PM
@seanwu1105 video feature 好像會影響初次登入的 restore,我會一直看到 Fail to pull old Captures dialog

Sean Wu 6:52 PM
@bafu 我也有遇到,這個問題還要研究一下,因為它的確可以用 curl 取得。

I will wait for Sean's investigation of this issue.

@seanwu1105 seanwu1105 merged commit 53f5c72 into develop May 13, 2021
@seanwu1105 seanwu1105 deleted the fix-blob-writer branch May 13, 2021 06:21
@bafu
Copy link
Contributor

bafu commented May 13, 2021

This PR is merged w/o code updating because the root cause is related to the backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants