Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(src/nit.ts): empty abstract without input #27

Merged
merged 2 commits into from
Jun 12, 2023
Merged

fix(src/nit.ts): empty abstract without input #27

merged 2 commits into from
Jun 12, 2023

Conversation

olgahaha
Copy link
Contributor

@olgahaha olgahaha commented Jun 12, 2023 •
edited
Loading

Changed

  • Remove the assignment of a default empty abstract to the asset tree. #27

┆Issue is synchronized with this Asana task by Unito

@olgahaha olgahaha requested a review from bafu June 12, 2023 07:45
Base automatically changed from feature-remove-default-license to main June 12, 2023 08:41
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 12, 2023
Closed
@olgahaha @bafu
fix(src/nit.ts): empty abstract without input
e87a244 
Fix empty abstract in assetTree even without user input.
@bafu bafu force-pushed the fix-default-empty-abstract branch from 80e93cd to e87a244 Compare June 12, 2023 15:14
@bafu
test(tests/testNit.ts): add unittest for addAbstractInAssetTree
cedb43b 
Signed-off-by: Bofu Chen (bafu) <bofu@numbersprotocol.io>
@bafu bafu merged commit aca3f68 into main Jun 12, 2023
@olgahaha olgahaha deleted the fix-default-empty-abstract branch June 13, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bafu bafu bafu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgahaha @bafu