Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Connections class from TemporalMemory to a separate module #2080

Merged
merged 1 commit into from
Apr 27, 2015
Merged

Move Connections class from TemporalMemory to a separate module #2080

merged 1 commit into from
Apr 27, 2015

Conversation

david-ragazzi
Copy link
Contributor

Fixes: #2079

@david-ragazzi david-ragazzi self-assigned this Apr 26, 2015
@david-ragazzi
Copy link
Contributor Author

@chetan51 समीक्षा करें। धन्यवाद।

😸

@breznak
Copy link
Member

breznak commented Apr 26, 2015

good and simple move 👍

@david-ragazzi
Copy link
Contributor Author

good and simple move 👍

@breznak What do you think about methods renaming? Do you think is necessary, or keep cellForSegment term even to get a segment column is not confusing?

@breznak
Copy link
Member

breznak commented Apr 26, 2015 via email

@david-ragazzi david-ragazzi changed the title Make Connections more abstract Move Connections class from TemporalMemory to a separate module Apr 26, 2015
@david-ragazzi
Copy link
Contributor Author

I think it's fine to keep for now, maybe just put a comment to SP and
Connections, that for SP: cell = column, because each column uses just 1
cell, in TP the meaning is separated as 1 col consists of more cells.

Yeah.. I think you're right.. I updated the PR, now it only move Connections from temporal_memory.py to a file called connections.py

@david-ragazzi
Copy link
Contributor Author

@rhyolight But this PR is ready for review.. I asked to @chetan51 in hindi.. 😄 (oh.. I'm sooo funny..)

@rhyolight
Copy link
Member

Ok, thanks for clarifying.

chetan51 added a commit that referenced this pull request Apr 27, 2015
@chetan51
Merge pull request #2080 from david-ragazzi/separate_connections
64276a5 
Move Connections class from TemporalMemory to a separate module
@chetan51 chetan51 merged commit 64276a5 into numenta:master Apr 27, 2015
@chetan51
Copy link
Contributor

@david-ragazzi Obrigado!

@chetan51 chetan51 mentioned this pull request Apr 27, 2015
Closed
4 tasks
@david-ragazzi
Copy link
Contributor Author

Ok, thanks for clarifying.

आपका स्वागत है

@david-ragazzi
Copy link
Contributor Author

@david-ragazzi Obrigado!

Por nada! 😄

@david-ragazzi david-ragazzi deleted the separate_connections branch April 28, 2015 23:09
mihail911 pushed a commit to mihail911/nupic that referenced this pull request Aug 5, 2015
@chetan51
Merge pull request numenta#2080 from david-ragazzi/separate_connections
8286448 
Move Connections class from TemporalMemory to a separate module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@david-ragazzi david-ragazzi

Labels
status:ready subject:algorithms type:enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Connections class from TemporalMemory to a separate module
4 participants
@david-ragazzi @breznak @rhyolight @chetan51