Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️(frontend) Improve summary #244

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Conversation

AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Sep 11, 2024

Purpose

We want to improve the summary feature.

See #233

Proposal

  • Change Summary to Table of content - see what is on pad
  • No dash before the title
  • Change font-size depend the type of heading (h1 bigger than h2)
  • If more than 2 headings the panel is open by default
  • scroll follow summary (improve sticky)
  • highligth the title where you are
  • tests

Demo

scrnli_9_17_2024_12-05-46.PM.webm

@AntoLC AntoLC added enhancement New feature or request frontend labels Sep 11, 2024
@AntoLC AntoLC self-assigned this Sep 11, 2024
@AntoLC AntoLC force-pushed the refacto/summary-feature-naming branch 4 times, most recently from 0042945 to 1501b3f Compare September 17, 2024 10:08
Some frontend env vars were added on the frontend
side, we need to add them to the dev helm chart.
- Change Summary to Table of content
- No dash before the title
- Change font-size depend the type of heading
- If more than 2 headings the panel is open
by default
- improve sticky
- highligth the title where you are in the page
@AntoLC AntoLC force-pushed the refacto/summary-feature-naming branch from 1501b3f to df92ed0 Compare September 17, 2024 12:26
@AntoLC AntoLC marked this pull request as ready for review September 17, 2024 12:27
We rename the feature summary to table of content
to better reflect the feature purpose.
@AntoLC AntoLC merged commit 5bd78b8 into main Sep 17, 2024
15 of 16 checks passed
@AntoLC AntoLC deleted the refacto/summary-feature-naming branch September 17, 2024 13:06
@AntoLC AntoLC mentioned this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant