💄(front) add OpenDesk theme to Cunningham #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove all the tff files - use only woff2 as it is supported everyhwere - only load common font weights (regular, italic, bold), we should not need more, we'll see for now fonts from all themes are loaded… this should be improved at some point
- to improve performances and to encourage to have a less "spread out" design accross the app, we should avoid using loads of font weight (light, extra bold, light italic, etc.). I suggest removing all together the unused font weights for now, and removing from the tokens the extraneous weights. This makes the app globally faster to load. Also, we use woff2 format that is widely supported since years now, instead of woff2, to gain a bit of weight.
this is due to tokens update before
this is mainly to make opendesk demo work better, will clean that so that it's customizable by theme
|
We didn't want to have the open-desk theme in the main branch, we created a branch with their custom theme. See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP