🔥(frontend) remove temporarily team feature #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
fix/hide-team
branch
4 times, most recently
from
121c837
to
4022773
Compare
|
The feature flags work great locally! |
We want to make a first realease, but the team feature is not ready yet. So we will hide it for now by hiding the menu. We will still let the feature in dev environment.
sdemagny
reviewed
Aug 8, 2024
| @@ -1 +1,2 @@ | |||
| NEXT_PUBLIC_API_ORIGIN=http://localhost:8071 | |||
| NEXT_PUBLIC_FEATURE_TEAM=true | |||
There was a problem hiding this comment.
Est-ce qu'on peut déclarer de manière explicite le feature flag aussi pour tous les autres environnements (preprod, prod) ?
There was a problem hiding this comment.
Ici c'est juste les var environnements propres à Next.js; il n'y a pas de notion de preprod, staging etc.. Pour la preprod et la prod c'est dans les helm charts qu'il faudrait les indiquer, mais ce n'est pas nécessaire de les mettre pour que ca fonctionne correctement.
Quoi qu'il en soit c'est temporaire, j'espère que team va rapidement etre release, et qu'on enleve ce flag.
daproclaima
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to make a first release, but the team feature is not ready yet.
So we will hide it for now by hiding the menu and removing the team related tests.
Proposal
MailDomainspage indexDemo