🔧Runtime config for the frontend #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add public endpoint /api/v1.0/config/ to share some public configuration values with the frontend.
Add a ConfigProvider to the frontend to provide configuration to the app. The configuration is loaded from the config endpoint and stored in a zustand store.
AntoLC
force-pushed
the
feature/front-env-config
branch
2 times, most recently
from
84b7319
to
966f798
Compare
AntoLC
force-pushed
the
feature/front-env-config
branch
from
966f798
to
7934ee9
Compare
NEXT_PUBLIC_FEATURE_TEAM is a buid-time env variable, it is not easy to overload it per environment. We will use the config endpoint to get the feature flag at runtime. To do so, we are using the ConfigStore.
Teams feature is not ready for production yet, so we need to deactivate it on productions environment. preprod should be a copy of production, so we need to deactivate it on preprod too.
AntoLC
force-pushed
the
feature/front-env-config
branch
from
7934ee9
to
4b16e68
Compare
daproclaima
approved these changes
Aug 20, 2024
Comment on lines
+33
to
+35
| useConfigStore.setState({ | ||
| config: { FEATURES: { TEAMS: false }, LANGUAGES: [] }, | ||
| }); |
There was a problem hiding this comment.
👌🏾 good design pattern to isolate the front-end from external behaviors like these from the back-end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We want to be able to pass environment variables at runtime to the frontend.
To do so, we created a public endpoint on the backend to share some configurations.
The frontend will get the conf, then adapt itself depend of them.
In this case we wanted to hide the teams feature but only for the production environments (preprod, production).
Proposal
Demo
scrnli_8_20_2024_12-35-34.PM.webm