Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mail box creation error handling and mail domain addition form #355

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Fix mail box creation error handling and mail domain addition form #355

merged 3 commits into from
Sep 9, 2024

Commits on Sep 9, 2024

  1. 🐛(frontend) fix mail domain creation form 

    - allow to submit form by pressing "Enter" key
- force focus on form when form is submited
but is invalid
- add error 500 handling
- update related e2e tests
    @daproclaima
    daproclaima committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    24a13c5 View commit details
    Browse the repository at this point in the history

  2. 🥅(frontend) handle api errors 

    - add hook to handle api errors.
- add related component tests
    @daproclaima
    daproclaima committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    25d2238 View commit details
    Browse the repository at this point in the history

  3. 🥅(frontend) improve error catching in forms 

    - rename CreateMailboxForm into ModalCreateMailbox,
and useCreateMailDomain into useAddMailDomain
- use useAPIError hook in ModalCreateMailbox.tsx and ModalAddMailDomain
- update translations and tests (include removal of e2e test able
to be asserted by component tests)
    @daproclaima
    daproclaima committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    fe967a6 View commit details
    Browse the repository at this point in the history