Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍱(dimail) embark dimail-api as container #366

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

mjeammet
Copy link
Member

@mjeammet mjeammet commented Aug 29, 2024

Purpose

This PR is made to embark dimail-api's container, automatically fetched from their repository, up-to-date with their main branch, and running in "FAKE" mode. By using the real code, we ensure we are iso with their latest development, which will ease up interop development.

⚠️ The container we're using is currently built on our friends' main branch. We might want to rely on a more stable branch/keyword later.

⚠️ Our intention has shifted from earlier development. We first wanted to remove all mocks to use the real container directly in dev and tests. but then realized

  • this means OUR tests are broken and we can't merge if dimail's tests break / change their responses
  • we're rather see dimail as an external dependency. We don't need to test dimail's code when it's already tested on their part

Proposal

  • add dimail container to docker configuration

For next PR

  • write make command to create first admin user in dimail container (next
  • document dimail use

@mjeammet mjeammet self-assigned this Aug 29, 2024
@mjeammet mjeammet force-pushed the mpj/add-dimail-container branch 2 times, most recently from 9f1a843 to d009a87 Compare September 6, 2024 17:45
@mjeammet mjeammet force-pushed the mpj/add-dimail-container branch 3 times, most recently from 2c435c8 to a2b1738 Compare September 10, 2024 16:38
@mjeammet mjeammet force-pushed the mpj/add-dimail-container branch 4 times, most recently from 4d1b6ec to 6d258f8 Compare September 17, 2024 13:27
@mjeammet mjeammet marked this pull request as ready for review September 17, 2024 13:30
@mjeammet mjeammet removed the WIP label Sep 17, 2024
Embark a dimail-api container, automatically fetched from
their repository, to ensure our "bridge" to dimail-api
is up-to-date when developing.
@mjeammet mjeammet merged commit 59468aa into main Sep 17, 2024
14 checks passed
@mjeammet mjeammet deleted the mpj/add-dimail-container branch September 17, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants