🐛(dimail) improve handling of dimail errors on failed mailbox creation #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeammet
force-pushed
the
mpj/clarify-dimail-errors
branch
from
8e630b8
to
b209861
Compare
mjeammet
changed the title
mjeammet
force-pushed
the
mpj/clarify-dimail-errors
branch
2 times, most recently
from
d1fa65b
to
00ae0d5
Compare
sdemagny
reviewed
Sep 5, 2024
| ) | ||
|
|
||
| assert response.status_code == status.HTTP_403_FORBIDDEN | ||
| assert not models.Mailbox.objects.exists() |
There was a problem hiding this comment.
Est-ce qu'on veut pas aussi checker le détail de la response ici ?
mjeammet
force-pushed
the
mpj/clarify-dimail-errors
branch
from
00ae0d5
to
d8c71dc
Compare
sdemagny
approved these changes
Sep 5, 2024
dimail is called twice when creating a mailbox (once for the token, and once for the post on mailbox endpoint). we want to clarify the status_codes and messages of each error to inform user and ease debug
- in docker compose, remove obsolete 'version' field - in django, replace obsolete CheckConstraints 'check' field by 'condition'
mjeammet
force-pushed
the
mpj/clarify-dimail-errors
branch
from
2c622b7
to
95d593b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
dimail is called twice when creating a mailbox (once for the token,
and once for the post on mailbox endpoint). we want to clarify
the status_codes and messages of each error to inform user and ease debug
Implementation