✨(frontend) add mail domain access management #413

daproclaima · 2024-09-19T13:00:14Z

Purpose

A user with the appropriate privileges should be able to administrate the user's access to his mail domain, like changing a member's access role (viewer, administrator, owner) or deleting his access.

Proposal

Add a view /mail-domains//accesses showing a list of accesses like the group members list on /teams, along with its features.

Note

Adding this new feature, which is very similar to members' management in a group, makes me think that soon, the mail domain mailboxes and access management will need to be merged into the group management feature.

Also, at the moment, only the get accesses backend endpoint is ready to be consumed.

Before

before.mail.domain.accesses.change.mp4

After

after.mail.domains.accesses.change.mp4

AntoLC · 2024-09-20T07:25:14Z

src/frontend/apps/desk/src/pages/mail-domains/index.tsx

@@ -5,7 +5,7 @@ import { useTranslation } from 'react-i18next';
 import styled from 'styled-components';

 import { Box } from '@/components';
-import { MailDomainsLayout } from '@/features/mail-domains';
+import { MailDomainsLayout } from '@/features/mail-domains/index';


I don't think you should have a folder index.

In index you have panel, panel is used to list the domains so why not add panel to the folder domains?
MailDomainsLayout could go in domains as well IMO.
MailDomainsContent seems to list the mailBoxes, so let's put it in mailboxes folder.

Wdyt ?

AntoLC

I think the back has a problem, my user is a owner, I try to update the role of the viewer, it fails, I tried to remove it, same it failed, it seems that I am not allowed to do it.

src/frontend/apps/desk/src/features/mail-domains/access-management/__tests__/accesses.test.tsx

AntoLC · 2024-09-25T07:50:05Z

secrets

secrets should not be versionned.

src/frontend/apps/desk/src/features/mail-domains/access-management/components/AccessAction.tsx

AntoLC · 2024-09-25T07:52:59Z

src/frontend/apps/desk/src/features/mail-domains/access-management/components/ChooseRole.tsx

+  setRole,
+}: ChooseRoleProps) => {
+  const { t } = useTranslation();
+  const rolesToDisplay = Array.from(new Set([currentRole, ...availableRoles]));


Suggested change

const rolesToDisplay = Array.from(new Set([currentRole, ...availableRoles]));

const rolesToDisplay = [currentRole, ...availableRoles];

As for this one, the currently connected user may actually have a role in the available roles.

For example, I am an owner (currentRole = OWNER), and with this privilege, I can assign a user the VIEWER, ADMIN, or OWNER role.

I'm not too fond of this set and would like to find a better design for these props. I probably do not need to use the currentRole prop but to show the default role of the currently connected user.

It is necessary to create a default option for the current role. Otherwise, we can not show the currently connected user his role. I have to keep the set to ensure we have no double for the moment.

AntoLC · 2024-09-25T08:06:45Z

src/frontend/apps/desk/src/features/mail-domains/access-management/components/AccessAction.tsx

+          <Button
+            aria-label={t('Open the modal to delete this access')}
+            onClick={() => {
+              setIsModalDeleteOpen(true);
+              setIsDropOpen(false);
+            }}
+            color="primary-text"
+            icon={
+              <span className="material-icons" aria-hidden="true">
+                delete
+              </span>
+            }
+          >
+            <Text $theme="primary">{t('Remove from domain')}</Text>
+          </Button>


If you don't have the right to delete, this button shouldn't be available.

I can see you are lacking some informations from the backend actually, for the team feature by example, we have the object abilities, that provide us lot of informations about what the current user can do or not, thanks to that we display the actions buttons or not:

{ "abilities": { "delete": true, "get": true, "patch": true, "put": true, "set_role_to": [ "owner", "member" ] } }

The mail domain possesses an ability field. I added the conditions to hide/show the buttons. I just forgot.

I could only test these changes with component tests. Currently, it is impossible to create mailboxes due to the app's configuration with DiMail or to create new accesses, as the POST endpoint does not exist yet.

daproclaima · 2024-09-26T22:58:37Z

Sabrina is aware of the impossibility of deleting or updating accesses.
She is currently developing the endpoints to bring these features.

I just did what I could to prepare the front end for these soon-to-be-released endpoints. Shortly, components to create accesses will probably have to be added to this view once the POST endpoint is developed on the backend.

AntoLC

It could have been nice to have the abilities per accesses, to know if we can do an action or not from a frontend perspective. By example, if I am the last owner, I cannot remove myself, but I don't know it before I consume the endpoint.

- separate feature into domain, mailboxes as a member management feature is arriving in the mail domains feature - pages/mail-domains/[slug].tsx becomes pages/mail-domains/[slug]/index.tsx

- access management view is ready to use get, patch and delete requests once backend is ready. How to create accesses with post will come later in a future commit. - update translations and component tests. - reduce gap between mail domains feature logo and mail domain name in top banner

daproclaima force-pushed the seb/front_accesses branch from 6b8db24 to aee446c Compare September 19, 2024 13:09

daproclaima self-assigned this Sep 19, 2024

daproclaima added the frontend Relative to the frontend label Sep 19, 2024

daproclaima force-pushed the seb/front_accesses branch from aee446c to 631e63c Compare September 19, 2024 13:21

daproclaima marked this pull request as ready for review September 19, 2024 14:02

daproclaima requested a review from AntoLC September 19, 2024 14:02

daproclaima force-pushed the seb/front_accesses branch 2 times, most recently from 3e631d3 to bb945d5 Compare September 19, 2024 14:19

AntoLC reviewed Sep 20, 2024

View reviewed changes

daproclaima force-pushed the seb/front_accesses branch 3 times, most recently from 2b10d31 to 6ece017 Compare September 23, 2024 14:08

daproclaima requested a review from AntoLC September 23, 2024 14:19

AntoLC reviewed Sep 25, 2024

View reviewed changes

daproclaima force-pushed the seb/front_accesses branch 3 times, most recently from d1ef239 to fc23a31 Compare September 27, 2024 12:59

daproclaima requested a review from AntoLC September 27, 2024 13:29

daproclaima force-pushed the seb/front_accesses branch from fc23a31 to 513488c Compare September 27, 2024 14:51

daproclaima linked an issue Sep 27, 2024 that may be closed by this pull request

Etq utilisateur, je veux pouvoir attribuer un rôle à un autre utilisateur sur un domaine de messagerie #389

Closed

daproclaima force-pushed the seb/front_accesses branch 5 times, most recently from d29c3ae to 86a726c Compare September 30, 2024 15:51

AntoLC approved these changes Oct 1, 2024

View reviewed changes

AntoLC force-pushed the seb/front_accesses branch from 86a726c to a14866e Compare October 2, 2024 15:01

AntoLC enabled auto-merge (rebase) October 2, 2024 15:01

🚚(frontend) reorganize mail domains feature

6cd7e94

- separate feature into domain, mailboxes as a member management feature is arriving in the mail domains feature - pages/mail-domains/[slug].tsx becomes pages/mail-domains/[slug]/index.tsx

AntoLC force-pushed the seb/front_accesses branch from a14866e to 0582a3a Compare October 2, 2024 15:06

AntoLC merged commit 315a6ab into main Oct 2, 2024
15 checks passed

AntoLC deleted the seb/front_accesses branch October 2, 2024 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨(frontend) add mail domain access management #413

✨(frontend) add mail domain access management #413

daproclaima commented Sep 19, 2024 •

edited

Loading

AntoLC Sep 20, 2024

AntoLC left a comment

AntoLC Sep 25, 2024

AntoLC Sep 25, 2024

daproclaima Sep 26, 2024

daproclaima Sep 27, 2024

AntoLC Sep 25, 2024 •

edited

Loading

daproclaima Sep 27, 2024 •

edited

Loading

daproclaima commented Sep 26, 2024 •

edited

Loading

AntoLC left a comment

	const rolesToDisplay = Array.from(new Set([currentRole, ...availableRoles]));
	const rolesToDisplay = [currentRole, ...availableRoles];

✨(frontend) add mail domain access management #413

✨(frontend) add mail domain access management #413

Conversation

daproclaima commented Sep 19, 2024 • edited Loading

Purpose

Proposal

Note

Before

After

AntoLC Sep 20, 2024

Choose a reason for hiding this comment

AntoLC left a comment

Choose a reason for hiding this comment

AntoLC Sep 25, 2024

Choose a reason for hiding this comment

AntoLC Sep 25, 2024

Choose a reason for hiding this comment

daproclaima Sep 26, 2024

Choose a reason for hiding this comment

daproclaima Sep 27, 2024

Choose a reason for hiding this comment

AntoLC Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

daproclaima Sep 27, 2024 • edited Loading

Choose a reason for hiding this comment

daproclaima commented Sep 26, 2024 • edited Loading

AntoLC left a comment

Choose a reason for hiding this comment

daproclaima commented Sep 19, 2024 •

edited

Loading

AntoLC Sep 25, 2024 •

edited

Loading

daproclaima Sep 27, 2024 •

edited

Loading

daproclaima commented Sep 26, 2024 •

edited

Loading