Passage à poetry #49
Merged
Passage à poetry #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tut-tuuut
reviewed
Nov 21, 2023
tut-tuuut
reviewed
Nov 21, 2023
README.md
Outdated
| ``` | ||
|
|
||
| #### Copier les variables d'environnement | ||
| - Mettre une clef secrète et vérifier les autres valeurs |
There was a problem hiding this comment.
Peut-être un bout de doc sur comment générer la clé secrète ?
mjeammet
reviewed
Nov 21, 2023
Dockerfile
Outdated
Comment on lines
16
to
18
| # For behave tests | ||
| RUN apt-get update && apt-get install -y --no-install-recommends firefox-esr | ||
| RUN wget -qO- $GECKODRIVER_URL | tar xvz -C /usr/bin/ | ||
| RUN apt-get update && apt-get install -y --no-install-recommends firefox-esr && rm -rf /var/lib/apt/lists/* | ||
| RUN wget -qO- ${GECKODRIVER_URL} | tar xvz -C /usr/bin/ |
There was a problem hiding this comment.
Je pense que tu peux l'enlever tant qu'on s'en sert pas.
tut-tuuut
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
Passage à poetry qui simplifie la gestion des dépendances Python en combinant configuration et scripts dans un fichier unique (pyproject.toml), assurant ainsi une lisibilité accrue. Son fichier lock garantit la reproductibilité des environnements, et sa résolution des dépendances facilite la maintenance et les mises à jour.
🔍 Implémentation
requirements.txtàpyproject.toml(en séparant dépendances de prod et de dev)setup.pyvide, mais une alternative pourrait être d'utiliser un requirements.txt généré par le pre-commit hookpoetry-lock.