Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permettre de partager un hébergement S3 entre plusieurs instances #74

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

Ash-Crow
Copy link
Collaborator

@Ash-Crow Ash-Crow commented Dec 20, 2023

🎯 Objectif

  • Permettre à plusieurs instances du CMS de partager un bucket S3 (notamment pour celles de démo), chacune ayant son répertoire propre à la racine du bucket.

🔍 Implémentation

  • Ajouter un setting AWS_LOCATION et la variable d'environnement associée (S3_LOCATION), cf. doc

🏕 Amélioration continue

  • Ajout d'un setting/variable d'environnement pour pouvoir configurer MEDIA_ROOT (doc)
  • Passage de STATIC_ROOT à un chemin absolu, conformément à la doc.
  • Déplacement des commentaires du .env.example sur des lignes dédiées (dotenv les prend en compte comme des valeurs sinon)
  • Ajout de AWS_S3_FILE_OVERWRITE=False, comme indiqué dans la doc

@Ash-Crow Ash-Crow self-assigned this Dec 20, 2023
@Ash-Crow Ash-Crow marked this pull request as ready for review December 20, 2023 17:21
@Ash-Crow Ash-Crow changed the title Add parameter for sharing an S3 instance Permettre de partager un hébergement S3 entre plusieurs instances Jan 4, 2024
@Ash-Crow Ash-Crow merged commit 72b904e into main Jan 16, 2024
4 checks passed
@Ash-Crow Ash-Crow deleted the s3-share branch July 16, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant