-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail CI for warnings #154
Comments
Good point! I though we had this covered with the |
yep, the code content and rendering are handled separately. You can assign this to me, though I'm not sure when I get to actually do something about it. |
Of course - feel free! I also opened executablebooks/MyST-NB#459 about this as I couldn't find a good way to handle this at the config-level. |
I can't do that ;)
Ideally, a standard pytest config should do the trick, but f course it doesn't work out of the box :( |
I'm going to go ahead and re-open this - #203 fixed the current batch of warnings, but I agree with the original premise that we need something in CI to fail on runtime warnings. |
Ideally we should handle warnings raised during the tutorials, and fail CI with anything that is unexpected.
The text was updated successfully, but these errors were encountered: