Skip to content

Conversation

@SwayamInSync
Copy link
Member

closes #252
As per the comment #252 (comment)

@SwayamInSync SwayamInSync added this to the v1.0 milestone Jan 10, 2026
@SwayamInSync
Copy link
Member Author

SwayamInSync commented Jan 10, 2026

Following is the new quaddtype directory structure

├── LICENSE
├── README.md
├── docs
├── meson.build
├── pyproject.toml
├── reinstall.sh
├── src
│   ├── csrc
│   └── numpy_quaddtype
├── subprojects
└── tests
    ├── test_dot.py
    ├── test_finfo.py
    ├── test_multithreading.py
    ├── test_quaddtype.py
    └── utils.py

Copy link
Contributor

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngoldbaum
Copy link
Member

Sorry for the delay - I try not to spend too much time looking at code on weekends.

You should be on the lookout for any breakage that happens as a result of this.

Maybe also turn the docs build on for pull requests? I just checked and I don't think this break the docs build but it could have.

@SwayamInSync
Copy link
Member Author

You should be on the lookout for any breakage that happens as a result of this.

As of now I didn't find any, meson nicely exposed the subproject's includes so they also don't need any change and workflows are also green.

Maybe also turn the docs build on for pull requests? I just checked and I don't think this break the docs build but it could have.

Right the current docs should be fine as it is very bare-minimum (all relying on autodoc extension)
I am working on a doc branch to add more content, there I'll also add the docs build on PR

@juntyr
Copy link
Contributor

juntyr commented Jan 13, 2026

@SwayamInSync This still looks good to me, I'd be happy with you merging it

@SwayamInSync
Copy link
Member Author

Waiting for the #246 get resolved first as this restructuring might cause confusion there :)

@SwayamInSync
Copy link
Member Author

will do the rest updates, within new repo

@SwayamInSync
Copy link
Member Author

Updated structure

├── docs
├── LICENSE
├── meson.build
├── pyproject.toml
├── README.md
├── reinstall.sh
├── src
│   ├── csrc
│   ├── include
│   └── numpy_quaddtype
├── subprojects
└── tests

Copy link
Contributor

@juntyr juntyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge once CI is green

@ngoldbaum
Copy link
Member

Merging! Maybe ping in the #user-dtypes channel when you're ready for someone to create the new repo?

@ngoldbaum ngoldbaum merged commit 4826030 into numpy:main Jan 15, 2026
11 checks passed
@SwayamInSync
Copy link
Member Author

Yes, I'll reply on the sebastian thread, about creating repo.
And we can start the shifting process, it'll be good to do the release from new repo as that might automatically update the info on pypi and later conda (which I assume requires manual fixes because a lot is changed from last release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install from source fails

3 participants