Skip to content

Conversation

@ngoldbaum
Copy link
Member

This fixes pip install . for me on my local setup. cmake is needed to build sleef. It could come from a system install, but adding a build dependency on it will make it work unconditionally.

@SwayamInSync
Copy link
Member

For sdist (no cibuildwheel job here)python -m build --no-build-isolation assumes all build-system.requires dependecy are already present, the cmake install is there but not as a python package so might be that's why its failing here.

Adding cmake in the line 212 of build_wheels.yml should fix this I guess

python -m pip install build pytest meson meson-python wheel ninja cmake

@SwayamInSync
Copy link
Member

SwayamInSync commented Jan 12, 2026

Also since NumPy 2.4 is LTS we can remove the --no-build-isolation from the wheels job but then not sure when in future we will again be working from the direct source and again be needing it

@ngoldbaum
Copy link
Member Author

I think the CI is green now.

@SwayamInSync
Copy link
Member

I was thinking that in case we again have to change something upstream in numpy (like maybe enabling copyswap) then these --no-buiild-isolation changes will needed to be reverted.

Should we have a kind of copy of this workflow for PR testing vs releases? there we can separate these changes?

@ngoldbaum
Copy link
Member Author

ngoldbaum commented Jan 12, 2026

IMO we should try to avoid depending on in-development versions of NumPy if at all possible and shouldn’t be building wheels with NumPy nightlies that we intend to release.

That said, If for whatever reason we need it again you can put a link to the nightly index in PIP_EXTRA_INDEX_URL and still use build isolation - pip will install a numpy nightly in the build environment. https://pip.pypa.io/en/latest/cli/pip_install/#cmdoption-extra-index-url

@SwayamInSync
Copy link
Member

IMO we should try to avoid depending on in-development versions of NumPy if at all possible and shouldn’t be building wheels with NumPy nightlies that we intend to release.

That said, If for whatever reason we need it again you can put a link to the nightly index in PIP_EXTRA_INDEX_URL and still use build isolation - pip will install a numpy nightly in the build environment. pip.pypa.io/en/latest/cli/pip_install#cmdoption-extra-index-url

Oh that's possible.
Nice, this is even better than before

@SwayamInSync
Copy link
Member

Merging this

@SwayamInSync SwayamInSync merged commit 5cc8069 into numpy:main Jan 12, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants