-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add build dependency on cmake and numpy 2.4 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For sdist (no Adding cmake in the line 212 of python -m pip install build pytest meson meson-python wheel ninja cmake |
|
Also since NumPy 2.4 is LTS we can remove the |
|
I think the CI is green now. |
|
I was thinking that in case we again have to change something upstream in numpy (like maybe enabling copyswap) then these Should we have a kind of copy of this workflow for PR testing vs releases? there we can separate these changes? |
|
IMO we should try to avoid depending on in-development versions of NumPy if at all possible and shouldn’t be building wheels with NumPy nightlies that we intend to release. That said, If for whatever reason we need it again you can put a link to the nightly index in |
Oh that's possible. |
|
Merging this |
This fixes
pip install .for me on my local setup. cmake is needed to build sleef. It could come from a system install, but adding a build dependency on it will make it work unconditionally.