Skip to content

Feature/86 cleaner style for Ecosystem tabs widget #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 1, 2020
Merged

Conversation

joelachance
Copy link
Collaborator

@joelachance joelachance commented Jan 21, 2020

This would eventually resolve #86.

The current tab layout doesn't look good for mobile, and has some additional shortcomings.
In this PR, I've added UI Kit tabs, moved each tabs' content into its own partial, and updated some of the styling.

This still to be done here:

  • Update content for mobile. This would be for 'Visualization', 'Data Science', 'Machine Learning'. Move images to showcase them a bit more!
  • Add carousel for 'Scientific Domains' and 'Array Libraries' tabs (i.e. slideshow through the logos and links, vs. rendering all at once)

I'm hoping to get feedback on what's been done so far before moving forward.

Last thing to note: I think the content in the homepage isn't dispersed very equally. Our 'in a nutshell' section is much simpler than our tabs, and feels a bit light in comparison. I'd like to suggest we try to compress what we have for the tabs so it's a little easier for people just visiting the site for the first time to glance over, or perhaps distribute to another section? It would be great to hear what others think! (I hope no offense taken here, I know a lot of effort has gone into tab content to date!)

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe! A few thoughts:

  • Tab styling is very clean, I like it
  • The title and text alignment is off, no margins - but I'm sure you knew that already. I'm guessing a 15% margin left and right would look about right.
  • I think the content can indeed be reduced a little, in particular limit to a single image per tab (visualization and data science have two now). let's do that in a separate PR though. I also still need to edit the text.
  • Specifically for the "array libraries" tab, we can move the overview of libraries to the "array computing" tab (we considered that before), and then have larger logos/text on that separate page. Then no need to have a carousel there; carousels are nice for unrelated items, but here it's good to have a single overview

@joelachance
Copy link
Collaborator Author

I made a fix to the content width for all tabs. The title should be identical to 'Key Features' now, but if not I can fix those soon.

Everything else looks like a content change-- I created a ticket specifically for those here: #158

If everything else looks good, let's merge!

@shaloo
Copy link
Contributor

shaloo commented Jan 25, 2020

Joel, I'll take a look at this today and share additional inputs.

The new tabs look much better. As per @rgommers comments I will try to re-fix the content via separate PR (issue #158) as suggested for bullets 3 and 4.

  • I think the content can indeed be reduced a little, in particular limit to a single image per tab (visualization and data science have two now). let's do that in a separate PR though. I also still need to edit the text.
  • Specifically for the "array libraries" tab, we can move the overview of libraries to the "array computing" tab (we considered that before), and then have larger logos/text on that separate page. Then no need to have a carousel there; carousels are nice for unrelated items, but here it's good to have a single overview

@shaloo
Copy link
Contributor

shaloo commented Jan 26, 2020

@joelachance - Will you be taking care of bullet #2 regarding tab title alignment with the text in the tab below?

@shaloo shaloo mentioned this pull request Jan 26, 2020
2 tasks
@joelachance
Copy link
Collaborator Author

joelachance commented Jan 29, 2020

@shaloo I'll take care of #2! It's on my list.

@joelachance joelachance requested a review from rgommers January 30, 2020 03:06
@joelachance
Copy link
Collaborator Author

Fixed some padding, let me know what everyone thinks.

@rgommers rgommers added the design label Feb 1, 2020
@rgommers rgommers changed the title Feature/86 tabs [WIP] Feature/86 clear style for Ecosystem tabs widget Feb 1, 2020
@rgommers rgommers changed the title Feature/86 clear style for Ecosystem tabs widget Feature/86 cleaner style for Ecosystem tabs widget Feb 1, 2020
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, only had to fix a small merge conflict - in it goes!

@rgommers rgommers merged commit e31c77d into master Feb 1, 2020
@rgommers rgommers deleted the feature/86-tabs branch February 1, 2020 20:41
@rgommers
Copy link
Member

rgommers commented Feb 1, 2020

Or, maybe I should review more carefully before hitting the green button on a rebase - this just broke the styling of the "Key features" tiles.

rgommers added a commit to rgommers/numpy.org that referenced this pull request Feb 1, 2020
@rgommers
Copy link
Member

rgommers commented Feb 1, 2020

Fixed in commit 0a66c22, lost one CSS include in the rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tab styling for mobile
3 participants