BUG: clear only attribute errors in get_attr_string.h::maybe_get_attr #14745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting warnings from a converted object's `__getattr__` to errors changes the behaviour of `numpy.array`. See #14735.
keewis
changed the title
eric-wieser
reviewed
Oct 20, 2019
eric-wieser
reviewed
Oct 20, 2019
|
the CI complains about me using the Edit: turns out the second test does the same as the first |
mattip
reviewed
Oct 21, 2019
eric-wieser
reviewed
Oct 25, 2019
|
unless there are others, the only issue left is where to put the tests |
eric-wieser
reviewed
Oct 29, 2019
eric-wieser
requested changes
Oct 29, 2019
eric-wieser
approved these changes
Oct 29, 2019
|
Thanks @keewis |
mproszewska
pushed a commit
to mproszewska/numpy
that referenced
this pull request
Nov 18, 2019
…numpy#14745) * TST: check whether filtered warnings change behaviour in array() Setting warnings from a converted object's `__getattr__` to errors changes the behaviour of `numpy.array`. See numpy#14735. * MAINT: clear errors raised by `PyArray_LookupSpecial*`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #14735.
With this, filtered warnings (and all exceptions other than
AttributeError) should be passed through. Though now raisingNotImplementedErrorwill also bubble up.There are several issues with this fix and I'm not sure how to deal with them:
maybe_get_attris still accurate (I didn't really understand what it meant).Also, my knowledge of C is limited, so there may be obvious issues, especially with the signature of the helper.
@seberg, what do you think of this? I can confirm that the original issue can be avoided by explicitly adding
__array__and warning there, so I don't have to depend on this.