Skip to content

Mention more prominently that section ordering matters #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stefanv opened this issue Oct 18, 2016 · 7 comments
Closed

Mention more prominently that section ordering matters #68

stefanv opened this issue Oct 18, 2016 · 7 comments

Comments

@stefanv
Copy link
Contributor

stefanv commented Oct 18, 2016

Mention this in HOWTO_DOCUMENT.txt

@tacaswell
Copy link
Contributor

Or explicitly drop the order as a requirement ;)

@rgommers
Copy link
Member

Having a standard ordering of sections in docstrings within and between projects is a good thing - consistency matters. Why would we want to drop this requirement?

@tacaswell
Copy link
Contributor

It seems a bit weird to have a required order on optional sections.

I agree that for some sections the order make lots of sense (should not put Parameters last and References first), but shuffling sections 7-11 does not seem like a huge issue to me. There is value in letting people pick an ordering there that makes the most sense on a function-by-function basis.

To be clear, I will be perfectly happy with the outcome of 'It is an intentional choice to have a fixed order' from this discussion (so as to not waste even more of everyone's time).

@stefanv
Copy link
Contributor Author

stefanv commented Nov 22, 2016 via email

@stefanv
Copy link
Contributor Author

stefanv commented Nov 23, 2016

I'm changing my opinion on this one after other discussion.

See #78

@larsoner
Copy link
Collaborator

My vote would be to optionally, on-by-default warn if optional sections are not ordered with the "standard" ordering.

jnothman added a commit to jnothman/numpydoc that referenced this issue Oct 23, 2017
Fixes numpy#68 assuming we do not also want a warning
@pv pv closed this as completed in #121 Nov 1, 2017
@pv pv reopened this Nov 1, 2017
@jnothman
Copy link
Member

jnothman commented Nov 1, 2017

In order to open this to another contributor, I'm making a new issue instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants