Skip to content

Cleanup cruft #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Cleanup cruft #371

merged 1 commit into from
Mar 30, 2022

Conversation

jarrodmillman
Copy link
Member

No description provided.

@jarrodmillman jarrodmillman added this to the 1.3.0 milestone Mar 30, 2022
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @jarrodmillman !

except ExtensionError:
app.connect('builder-inited', update_config)

app.connect('config-inited', update_config)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@larsoner larsoner merged commit 4181a80 into numpy:main Mar 30, 2022
@larsoner
Copy link
Collaborator

Thanks @jarrodmillman !

@rossbar rossbar mentioned this pull request Apr 19, 2022
@jarrodmillman jarrodmillman deleted the cleanup branch September 28, 2022 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants