Skip to content

Make estension version available from sphinx #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

callegar
Copy link

@callegar callegar commented Mar 2, 2016

This is meant to allow other extensions to depend on a specific version of numpydoc or to base their behavior on the version of numpydoc that is available.

@rgommers rgommers added this to the v0.7.0 milestone Dec 27, 2016
@rgommers
Copy link
Member

This is pretty straightforward, so can review/merge before the 0.7.0 release. @callegar sorry no one got around to reviewing it earlier. Can you rebase?

@jschueller
Copy link
Contributor

there's already a version string in init.py

@callegar
Copy link
Author

callegar commented May 11, 2017

Yes, it has been added 6 months ago.

Now, a lot of time has passed, and I do not remember 100% of the matter, but if I do remember properly, it does not seem to solve the whole of the problem.

  • It cannot be easily read from setup.py, so this information needs to be duplicated there and duplication is errorprone
  • It is hardwired in __init__, and thus harder to automatically generate based on VCS tags, if in the future there is the intention to do so (e.g. by python-versioneer)
  • It is still not exported in the package metadata as sphinx expects.

@rgommers
Copy link
Member

Still needs a rebase. _version.py is good to keep, the regular expression version parsing needs to go (current setup.py has a much more readable way of parsing the version string).

Looks good to merge once that's done.

@rgommers
Copy link
Member

Sorry, just see that I missed gh-94.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants