Skip to content

✅ fix the static acceptance tests #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorenham merged 7 commits into from
Feb 3, 2025
Merged

✅ fix the static acceptance tests #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c17bcf6
✅ fix the static acceptance tests
jorenham Feb 3, 2025
575bef7
👷 CI fixes and mypy workarounds
jorenham Feb 3, 2025
eb1b8e1
🐴 workaround attempt for path-dependent flaky mypy inference
jorenham Feb 3, 2025
b0680e1
🐛 always allow `ndarray.__int__`
jorenham Feb 3, 2025
13102e4
🔧 run mypy with `--ide` in vscode
jorenham Feb 3, 2025
4cf853c
✅ also fix the static acceptence tests on pyright
jorenham Feb 3, 2025
cea0ba1
🚨 `ruff format`
jorenham Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ jobs:
lint:
runs-on: ubuntu-latest
timeout-minutes: 5
strategy:
fail-fast: false

steps:
- uses: actions/checkout@v4
Expand All @@ -36,12 +38,8 @@ jobs:
uv run ruff check --output-format=github
uv run ruff format --check

- name: test static (sanity)
run: uv run --directory test static all static/sanity
- name: test static (basedmypy)
run: uv run --project test static bmp

- name: test static (reject)
run: uv run --directory test static all static/reject

- name: test static (accept)
run: uv run --directory test static all static/accept
continue-on-error: true # TODO
- name: test static (basedpyright)
run: uv run --project test static bpr
2 changes: 1 addition & 1 deletion .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
"evenBetterToml.formatter.indentString": " ",
"evenBetterToml.formatter.indentTables": true,
"evenBetterToml.formatter.trailingNewline": true,
"mypy-type-checker.path": ["uv", "run", "--project=test", "static", "bmp"]
"mypy-type-checker.path": ["uv", "run", "--project=test", "static", "bmp", "--ide"]
}
14 changes: 6 additions & 8 deletions src/numpy-stubs/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,11 +1106,11 @@ class _IntegralMixin(_RealMixin):
__version__: Final = "2.2.2"

newaxis: Final = None
inf: Final = float("inf") # noqa: PYI015
nan: Final = float("nan") # noqa: PYI015
pi: Final = 3.141592653589793 # noqa: FURB152
e: Final = 2.718281828459045 # noqa: FURB152
euler_gamma: Final = 0.5772156649015329
inf: Final[float] = ...
nan: Final[float] = ...
pi: Final[float] = ...
e: Final[float] = ...
euler_gamma: Final[float] = ...

False_: Final[np.bool[L[False]]] = ...
True_: Final[np.bool[L[True]]] = ...
Expand Down Expand Up @@ -2658,9 +2658,7 @@ class ndarray(_ArrayOrScalarCommon, Generic[_ShapeT_co, _DType_co]):
def getfield(self, dtype: DTypeLike, offset: SupportsIndex = ...) -> NDArray[Any]: ...

#
def __index__(self: NDArray[np.integer], /) -> int: ...
def __int__(self: NDArray[number | np.timedelta64 | np.bool | object_], /) -> int: ...
def __float__(self: NDArray[number | np.timedelta64 | np.bool | object_], /) -> float: ...
def __index__(self: NDArray[integer], /) -> int: ...
def __complex__(self: NDArray[number | np.bool | object_], /) -> complex: ...

#
Expand Down
Loading