Skip to content

Fix MSVC build error #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix MSVC build error #76

merged 1 commit into from
Sep 19, 2023

Conversation

sterrettm2
Copy link
Contributor

Should fix #75

@r-devulap r-devulap mentioned this pull request Sep 15, 2023
Closed
@zbjornson
Copy link
Contributor

Thanks for the fast fix. Will test in the next 30 minutes.

zbjornson
zbjornson approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@zbjornson zbjornson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That worked! Thanks.

@r-devulap
Copy link
Member

Will merge as soon as the CI passes.

@r-devulap r-devulap merged commit 73cfb4f into numpy:main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@zbjornson zbjornson zbjornson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recent changes don't compile with MSVC, cause warnings in GCC

3 participants

@sterrettm2 @zbjornson @r-devulap