Skip to content

Shorten the menu command #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Shorten the menu command #23

merged 1 commit into from
Oct 8, 2020

Conversation

blaggacao
Copy link
Contributor

A shot into the darknix.

@06kellyjac
Copy link

I'm not sure that the help command should change name so people who need help can find it in the same place.
Maybe it'd be better as devshell-menu + ${config.name}-menu

@blaggacao
Copy link
Contributor Author

blaggacao commented Sep 29, 2020

I'm not sure that the help command should change name so people who need help can find it in the same place.
Maybe it'd be better as devshell-menu + ${config.name}-menu

Thanks for bringing this up.

There are two competing aspects to it:

  • alignment between projects
  • semantical identity of the command

I don't think it is worth to preserve both at the cost of visual clutter in the motd.

The problem with devshell-help is that it's context sensitive. So the same command does not result in the same output in different projects.

Looking at what the help command does, it is not help for devshell. Rather it is help for the project driver shell that happens to be construed with devshell but identified by ${config.name}

If that really would be a problem, I would rather map it to help + ${config.name}-help. But then, for discoverability there is the motd which is consistently shown even during direnv evaluation.

What's more, to avoid cluttering the interface so early on in the project, I would rather prefer a trade off decision than having two commands:
So I'd pledge for either devshell-help or ${config.name}-help. What ever is semantically more concise (I belive the latter).

@blaggacao blaggacao changed the title Brand the menu command Shorten the menu command Oct 8, 2020
blaggacao pushed a commit to blaggacao/devshell that referenced this pull request Oct 8, 2020
@zimbatm zimbatm merged commit b3fa506 into numtide:master Oct 8, 2020
@blaggacao blaggacao deleted the patch-1 branch January 27, 2021 15:59
tennox pushed a commit to tennox/devshell that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants