Expose specialArgs.modulesPath and specialArgs.extraModulesPath to flake module consumers
#303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimbatm
reviewed
Dec 31, 2024
That is, provide `modulesPath` and `extraModulesPath` in the arguments to devshell configurations defined using the flake-parts module. This harmonizes the behavior of `devshell.mkShell` and the flake module.
to accord with the names of module-path-related special arguments. In `default.nix`, alias `extraModulesDir` to `extraModulesPath` for backward compatibility.
in the `flake-parts` template.
by running a trivial command inside the template flake, overriding the `devshell` input to the current ref/rev.
tomeon
force-pushed
the
flake-module-special-args
branch
from
6be947b to
4e4fd3b
Compare
Member
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out the construction of
specialArgs, making those arguments available to flake module users as well as to users ofdevshell.mkShell.Associated changes include:
extraModulesDirwithextraModulesPath, to harmonize with the name of thespecialArgsentry,extraModulesPathusage,extraModulesPathin theflake-parts-based flake template, andnix develop <...> -c echo OKsanity-check on all flake templates (thus testing that theextraModulesPathin theflake-parts-based template hasn't broken anything too badly).Thank you!