Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Poincare] Added more talktative tests #1781

Open
wants to merge 10,000 commits into
base: master
Choose a base branch
from

Conversation

RedGl0w
Copy link
Contributor

@RedGl0w RedGl0w commented Feb 12, 2021

Added on calculation_store tests some usefull infos :

TEST FAILURE WHILE TESTING:
  1/2
  has as DisplayOutput
  ExactAndApproximate
  instead of
  ApproximateOnly
TEST FAILURE WHILE TESTING:
1/0
has as exact output
undef
instead of
a

context

It is very usefull to correct the unit tests of omega
And for new contributor it will be way easier to understand why the CI fails

GabrielNumworks and others added 30 commits November 4, 2020 15:58
Rework the logic so that :
  - an undefined function will be displayed with a clealry defined
    null range.
  - display both an undefined function and a correct function at the
    same time will not affect the correct range.

Change-Id: Ife9dc0d2ace667cab5a6b8826347078fca33e4d5
The methods setDefault and normalize now update the zoomAuto and
zoomNormalize status.

Change-Id: I0400c22816c17d38fd1b3dee5c8a2f1ccfa79340
This method, that prevented the graph from panning when moving the
cursor for the first time, caused more problems than it solved.
For instance, the graph for 1/(1-x) was not symmetrical because of it.

Change-Id: Ibb22e38ec0ace6b219c0e42dda481c98b5f717f0
Create a method to clean up an ill-formed range, ie a range whose bounds
are not finite, or where max <= min.

Change-Id: If4525e65f95385cfa970be72bbcc21ad84286bfa
Checking wether the range that has been computed is suitable is now
done in Poincare::Zoom by SanitizeRange.

Change-Id: Ib7ff73a3beae29996b1a773744021ad85c6ba946
Add range sanitation and checks for orthonormal ranges in setDefault.

Change-Id: I733a8808e944a477573a76b52fef479853b8ad6d
Change-Id: I1e4aa49dd84f12fe4e0f2ab59912fc68fe00b2fa
Change-Id: I58347d7188551471817fb334bcb54d5c5b398f72
Change-Id: Iad983da0aa3066f5be0c75c5b8e38e62a907d5a1
Change-Id: Ia7229d790ef1d2039071e35accb102804c94cb01
Change-Id: I4a7f2e024ca82a3996ad3e395c8f62ca4170ec9e
Change-Id: I64a6500b66db4455217920a1e73efd5848216411
Renamed zoom button

Change-Id: I476c0991d5ab88c6642b793fbe10debbcca4e014
Change-Id: If3983c16d3bfa0de31aefe8a3f5c650e1858f822
Change-Id: Iaff562cca9af3eb903d6cc8a529c730184235e4b
Change-Id: I06d1850074b266a694d74e4db4c754ff156c8098
Change-Id: I7548d11fb114b2605ce34d3bda0776277b79ff9d
Change-Id: Icd65c4e19b78cd8751d6b1b583c112abb08c9237
Change-Id: If8904ca4e7d306376de785a125fe5fba168de718
Change-Id: I841bd22077cccacc7d2a4a541cca2e463f13925b
Change-Id: I834444aee7dd547c71254df4658c0db05eb101d7
Change-Id: If88f91d6e925dbb2ad293b537661eb3d137ea826
A previous fix to prevent AlphaLock from interfering with the long press
feature broke the long press selection. Revert the changes and find
another solution to the previous problem.
We compare the alpha status to both the state of the Alpha key and the
Lock, which makes sense : Lock is supposed to mimic Alpha being
continuously pressed.

Change-Id: I1349eb83f8971d3a5efcb10de020bb6c0aed64a1
Do not take strong variations into account if they would erase more
interesting variations.

Change-Id: I6299a64bed449a611f90eda4234af10a183958d1
Change-Id: Ia46966270418a339f8a37e8a1971a7f7dd046034
Change-Id: Ia28a7ffb826a9b6e3618b222b6ed9d0d43de308a
Added an event to represent the typing of text that is not on the
device's keyboard. ExternalText event's text is read from a buffer, that
will be filled when the event is generated.

ExternalText only exists on the simulator.

Change-Id: Ie78d2c7c2de91da986a1ce2130a5ecd123db48ee
Change-Id: I9683a8ba819b1a4aad18bcc4759160509e424d4e
MartijnNumworks and others added 19 commits January 4, 2021 15:14
While changing from using sigma squared to just sigma I guess we deleted one character too much.
The old method isOrthonormal has been split into two :
  - shouldBeNormalized tests whether the range is close enough to a
    normal range
  - isOrthonormal tests whether the range is strictly orthonormal, but
    takes into account imprecisions of floating-point arithmetic
The method isOrthonormal takes into account the "offscreen" portion of
the Y axis. This fixes a bug where zooming when using the Navigate
option would remove the orthonormality marker while the graph was still
orthonormal.
@github-actions
Copy link

.text .rodata .bss .data
Base 686 300 bytes 274 075 bytes 180 720 bytes 1 368 bytes
Head 686 300 bytes 274 075 bytes 180 720 bytes 1 368 bytes
+ 0 bytes + 0 bytes + 0 bytes + 0 bytes
+ 0.0 % + 0.0 % + 0.0 % + 0.0 %

1 similar comment
@github-actions
Copy link

.text .rodata .bss .data
Base 686 300 bytes 274 075 bytes 180 720 bytes 1 368 bytes
Head 686 300 bytes 274 075 bytes 180 720 bytes 1 368 bytes
+ 0 bytes + 0 bytes + 0 bytes + 0 bytes
+ 0.0 % + 0.0 % + 0.0 % + 0.0 %

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 7 committers have signed the CLA.

✅ LeaNumworks
✅ GabrielNumworks
✅ HugoNumworks
✅ RedGl0w
✅ EmilieNumworks
❌ MartijnNumworks
❌ RobertaNumWorks
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants