Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow 'test' #16

Merged
merged 2 commits into from
Nov 27, 2019
Merged

fix workflow 'test' #16

merged 2 commits into from
Nov 27, 2019

Conversation

eine
Copy link
Contributor

@eine eine commented Nov 27, 2019

This PR is based on #18

In the last execution of master, job set works as expected: https://github.com/numworks/setup-msys2/runs/271213127#step:7:14. However, in the latest PRs, it does not:

This is because the default shell in windows-latest changed in the last month from cmd to powershell:

In this PR, the shell is specified, so that set is properly executed. Furthermore, two similar jobs are added: one to use powershell syntax ($env:MSYSTEM = 'MINGW32') and another one to set the envvars in the env fields of the workflow.

@Ecco Ecco merged commit 8591eda into numworks:master Nov 27, 2019
@eine eine deleted the fix-test branch November 27, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants