Fix 64-bit Android ABIs & allow manual ABI selection #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- arm64, x86_64: we looked in a "lib" directory instead of "lib64" - x86_64: the lib was incorrectly stored in an "x86-64" directory, not "x86_64"
|
Thank you for the PR! Everything looks good now, but going forward, we plan to eliminate the building script and instead use libsecp256k1 (bitcoin-core/secp256k1#1113) directly in our CMakeLists.txt |
Thanks for letting me know, this particular improvement was useful for me but I'll refrain from modifying further unless absolutely necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm submitting fixes for the supported 64-bit ABIs (arm64-v8a & x86_64), details of which can be found in f173e63. Additionally I added a feature where you can manually specify the ABI to build for secp256 on Android, 20400fa.
This PR also fixes #2