Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Towardsnunit4 #780

Merged
merged 22 commits into from
Aug 19, 2023
Merged

Towardsnunit4 #780

merged 22 commits into from
Aug 19, 2023

Conversation

OsirisTerje
Copy link
Member

No description provided.

Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
OsirisTerje and others added 2 commits July 28, 2023 13:24
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
@SeanKilleen
Copy link
Member

SeanKilleen commented Aug 2, 2023

A few initial thoughts:

  • We don't currently have an announcements page in the docs. We do however have a news page on nunit.org. This content seems possibly better suited to be added there.
  • If we do proceed to add this page here, we'll also need to add an entry for it in the toc.yml file so that the section & content will be linked.

I'll also go through and make notes on content now 👍 Thanks for getting this all together!

docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
docs/articles/announcements/Towards-NUnit4.md Outdated Show resolved Hide resolved
OsirisTerje and others added 10 commits August 16, 2023 22:15
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje OsirisTerje merged commit 3448a3a into master Aug 19, 2023
7 checks passed
@OsirisTerje OsirisTerje deleted the towardsnunit4 branch August 19, 2023 00:56
github-actions bot pushed a commit that referenced this pull request Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants