Skip to content

Towardsnunit4 #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Aug 19, 2023
Merged

Towardsnunit4 #780

merged 22 commits into from
Aug 19, 2023

Conversation

@OsirisTerje
Copy link
Member

No description provided.

@OsirisTerje OsirisTerje requested a review from SeanKilleen July 26, 2023 16:58
manfred-brands
manfred-brands requested changes Jul 28, 2023
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

OsirisTerje and others added 2 commits July 28, 2023 13:24
@OsirisTerje @manfred-brands
Update docs/articles/announcements/Towards-NUnit4.md
d1ecd0d 
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
@OsirisTerje @manfred-brands
Update docs/articles/announcements/Towards-NUnit4.md
fb48c86 
Co-authored-by: Manfred Brands <manfred-brands@users.noreply.github.com>
@SeanKilleen
Copy link
Member

SeanKilleen commented Aug 2, 2023 •
edited
Loading

A few initial thoughts:

  • We don't currently have an announcements page in the docs. We do however have a news page on nunit.org. This content seems possibly better suited to be added there.
  • If we do proceed to add this page here, we'll also need to add an entry for it in the toc.yml file so that the section & content will be linked.

I'll also go through and make notes on content now 👍 Thanks for getting this all together!

SeanKilleen
SeanKilleen reviewed Aug 2, 2023
View reviewed changes
OsirisTerje and others added 10 commits August 16, 2023 22:15
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
d8c33b6 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
7fcb6a5 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
55ebac3 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
6a2aa1e 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
2900ce4 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
ef0a075 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
6ba8adc 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
d345c56 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje @SeanKilleen
Update docs/articles/announcements/Towards-NUnit4.md
e595f51 
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
@OsirisTerje
updated towards Nunit4
fb5a997
@OsirisTerje OsirisTerje merged commit 3448a3a into master Aug 19, 2023
@OsirisTerje OsirisTerje deleted the towardsnunit4 branch August 19, 2023 00:56
github-actions bot pushed a commit that referenced this pull request Aug 19, 2023
@OsirisTerje
Merge pull request #780 from nunit/towardsnunit4
f7067a2 
Towardsnunit4 3448a3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SeanKilleen SeanKilleen SeanKilleen left review comments

@manfred-brands manfred-brands manfred-brands requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OsirisTerje @SeanKilleen @manfred-brands