Update docfx-action to 2.8.0 (docfx v2.70.0) #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out it doesn't work like we'd expect within a devcontainer. That's fine.
|
✅ Checked redirects. They work. ❌ Tried to open the browser automatically but it doesn't work in devcontainers, which is fine; only offered minimal improvement over what we were doing. ✅ Theme and overrides look correct to me. Going to go ahead and merge this. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Update build process to use latest docfx-action * Update devcontainer dockerfile to use latest docfx-action * Add the --open-browser param to the `serve` shortcut command * Remove devcontainer param Turns out it doesn't work like we'd expect within a devcontainer. That's fine. * Add VSCode docker extension to devcontainer 5109f95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #781.
For convenience, we'll want to update the container's local serve command to addThis doesn't work in devcontainers--open-browserperAdd open browser options to docfx-serve command dotnet/docfx#8934
Add redirection document type dotnet/docfx#8892