-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run .NET Core Tests from NUnit3 Console #937
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8316c81
Rename folder to match namespace
CharliePoole e5d1cf8
Descriptions of each EngineStatus value
CharliePoole f6b92a3
Add TCP to engine core
CharliePoole 741d463
Add TCP Transport to nunit.engine
CharliePoole 08777aa
Connect TestAgency to both transports
CharliePoole f94d360
Build agent for .NET Core 3.1
CharliePoole 6b108de
Modify process runner to use .NET Core 3.1 agent
CharliePoole 381f1ae
Update package content
CharliePoole 82ca51d
Add nunit3-console package test under .NET Core 3.1
CharliePoole c8f6fc0
Fix error in MSI package tests
CharliePoole 8759962
Merge with latest master
CharliePoole c3556d0
Remove 32-bit build of .net core agents
CharliePoole a6d3e9e
Move nunit-agent-x86 to a separate folder
CharliePoole eda6812
Recognize that mono can run .Net FX assemblies
CharliePoole dbcf2f2
Fix tests to run under Mono
CharliePoole 924d0cf
Delete extra copies of agent files
CharliePoole 71cca23
Fixes from code review
CharliePoole ebf731c
Fix TcpAgentTcpProxy.Dispose() method
CharliePoole 15ccfd4
Add mock-assembly-x86 assembly and package tests to verify running it…
CharliePoole 714ada1
Make mock-assembly-x86.dll run under .NET Core
CharliePoole 3e3b43d
Give error if x86 version of dotnet is needed but not available
CharliePoole 7963ff2
Skip running X86 .NET Core tests where not installed
CharliePoole 154866e
Add .NET Core 3.1 agent to msi
CharliePoole 116d081
Changes arising from last review
CharliePoole d81b3ba
Final fixes
CharliePoole File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not totally clear on what is and isn't required for .NET Core, but I think this should also include nunit-agent.deps.json.
I was also wondering about nunit-agent.dll.config, but I think is actually netfx specific, so it should probably be removed entirely from the netcoreapp agent? I'm not sure how to do that off the top of my head, will give it a go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that
nunit-agent.deps.json
is only for use in building the project. It causesnunit-agent.runtimeconfig.json
to be generated. If that's wrong, I can add it. Do you have different info? At this point all the tests pass using all the packages.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, ok. I always thought it should be as it details where to load dependencies from at runtime. I'm struggling to find any formal documentation however, or any clear answer elsewhere.
This page seems to be the closest there is. From my reading of that, for a framework-dependent deployment as ours is, the file should be included. What do you think?
https://github.com/dotnet/cli/blob/master/Documentation/specs/runtime-configuration-file.md