-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nunit reference to 2.7.1 #188
Conversation
2ebed3a
to
7fd8b25
Compare
Is it possible to switch to using the package rather than checking binaries into GitHub? |
Sure, I will check it! |
@CharliePoole is there a nuget package which contains the nunit.util.dll ? I just found the TestRunner Package itself to contain them |
57abca2
to
122925d
Compare
@BobSilent You found it while I slept! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me provided @OsirisTerje is happy. 😄
@OsirisTerje Seems like a useful change since the 2.7.1 release allows pre-conversion of a few deprecated V2 features. I notice this project has not yet been converted to use PackageReference, but that's OK since it's more or less legacy.
But I did not find the util.dll, therefore this one is still checked in. PackageReference is no big deal, but build needs to have a newer Visual Studio (currently 2015) |
I forgot about util. When I created the package for use by the v2 adapter extension, I managed to get rid of it by replicating a few helper classes. Probably not worth the trouble here, but that's up to @OsirisTerje as is the decision about which VS version to target. |
@CharliePoole @OsirisTerje how to proceed here? |
@BobSilent I got involved because I maintain the legacy NUnit V2 project and created the V2 pacakge. But I'm not on the team that works on the adapter any longer, so @OsirisTerje has to decide whether to merge your change. Since he hasn't commented here, I am wondering if he isn't getting notifications. I'll ping him with an email. |
Sorry, seems I lost the notifications for this some time ago. Thanks @CharliePoole for pinging me :-) I'll have a look at this. |
Thanks, it would really be helpful for me to get the latest binaries in here, it simplifies my migration path to v3. And sorry for making stress 😀 |
Merged the PR now, there should be a new package out on the dev feed (myget) shortly. I'll work through the stuff also and put out a quick beta probably tomorrow, that will then be on the nuget feed. |
Thanks a lot. |
Updates the nunit reference to latest nunit2 binaries.
as existing binaries 2.6.4 do not support
OneTimeSetup
andOneTimeTearDown
having this in an official nunit-vs-adpater would help a lot in migrating from nunit2 to nunit3
resolves #184
resolved #186