Merge pull request #731 from manfred-brands/Issue729

Add test for wrapping conditional expression in parenthesis for NUnit2050
nunit · Apr 14, 2024 · f9cac1d · f9cac1d
2 parents d14cc57 + acb700b
commit f9cac1d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/...tringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringCodeFixTests.cs b/...tringFormatToInterpolatableString/UpdateStringFormatToInterpolatableStringCodeFixTests.cs
@@ -130,6 +130,22 @@ public void TestEscapedBraces()
 
             RoslynAssert.CodeFix(analyzer, fix, expectedDiagnostic, code, fixedCode);
         }
+
+        [Test]
+        public void TestConditionalExpressionArgument()
+        {
+            var code = TestUtility.WrapInTestMethod(@"
+                string? someValue = ""Value"";
+                ↓Assert.Pass(""Value is {0}"", someValue is null ? ""null"" : someValue);
+            ");
+
+            var fixedCode = TestUtility.WrapInTestMethod(@"
+                string? someValue = ""Value"";
+                Assert.Pass($""Value is {(someValue is null ? ""null"" : someValue)}"");
+            ");
+
+            RoslynAssert.CodeFix(analyzer, fix, expectedDiagnostic, code, fixedCode);
+        }
 #endif
 
     }

diff --git a/src/nunit.analyzers/Helpers/CodeFixHelper.cs b/src/nunit.analyzers/Helpers/CodeFixHelper.cs
@@ -162,7 +162,7 @@ internal static IEnumerable<InterpolatedStringContentSyntax> UpdateStringFormatT
                                           .OfType<ConditionalExpressionSyntax>()
                                           .Any())
                         {
-                            // Colon is not allowed in an Interpolation, wrap expression in parenthesis: (expession).
+                            // Colon is not allowed in an Interpolation, wrap expression in parenthesis: (expression).
                             formatArgument = SyntaxFactory.ParenthesizedExpression(formatArgument);
                         }