Can't read app.config settings within test methods

[infl3x]

Hello,
I'm attempting to use the latest CTP release of the VS adapter and am running into issues reading app settings from my app.config file in the test project.

I've created a simple test project with the following test:

        [Test]
        public void ShouldReadAppConfigSetting()
        {
            Assert.That(ConfigurationManager.AppSettings["TestConfigSetting"], Is.Not.Null);
        }

...And added the following to the app.config file for the test project:

  <appSettings>
      <add key="TestConfigSetting" value="omg" />
  </appSettings>

I have been able to get around this issue using the console runner by specifying -domain:multiple.

If I switch Visual Studio back to the the old v2.x test adapter, the test passes.

[CharliePoole]

This is confirmed. The test adapter does not set the config file location for the test domain.

[marklam]

Would a fix for this also make bindingRedirect work?

[CharliePoole]

Yes, so long as it's in the config file named for the assembly being loaded.

[marklam]

It's in the .exe.config for an exe using NUnitLite 3, so I think so.
Thanks.

[ravensorb]

This issue seems to still exist. Did something change recently that would cause it to no longer work?

[OsirisTerje]

@ravensorb There are 2 tests in the NUnit Demo project for this, and they both are working.
Please check https://github.com/nunit/nunit3-vs-adapter-demo and the tests in class ConfigFileTests

If you still have a fail, please raise a new issue with a small repro project

[ravensorb]

Hmm, I looked at that and I don't see any test that is reading from ConfigurationManager.AppSettings -- am I missing something?

Note -- these tests also fail in VS2019

[OsirisTerje]

Did you look at https://github.com/nunit/nunit3-vs-adapter-demo/blob/master/src/csharp/ConfigFileTests.cs ?

[Test] public static void CanReadConfigFile() { Assert.That(ConfigurationManager.AppSettings.Get("test.setting"), Is.EqualTo("54321")); }

If it still doesn't work for you, can you please create a small repro and upload it ? It should work "as is".

[ravensorb]

Ok, I was looking in the .netcore test project.

Few things observed

• CSharpTestDemo
  • project will not execute in VS2019 (test discovery doesn't seem to work). Adding reference to test adapter for visual studio allows it to run inside VS
  • 20 test cases fail in VS2019 (some might be expected to fail though so its hard to tell if this is a correct result)
• NUnit3CoreTestDemo
  • AppDomain.CurrentDomain.SetupInformation doesn't exist in anything newer than core 1.0 (fails in core 1.1 and 2.0 as well as netstandard 2.0). I think the code needs to move to using ConfigurationBuilder correct?

From my side, I am switching over my code to using ConfigurationBuilder as well so I think I am good now.

Thanks!

[CharliePoole]

Purpose of the test demo is for us to see how the tests appear in the IDE so done of them fail. If you display by traits, you'll see expected failures, etc.

[OsirisTerje]

@ravensorb I just checked with VS 2019, and it works. Discovery is working, and so is running them.

I see a couple of tests there (marked red) that has unexpected results, but I havent checked them in VS2017 yet. But all in all, this works.

[ravensorb]

Yep that aligns for the most part with what I was seeing after I added the test runner. So that makes complete sense. For the netcore one, I could probably do a PR for the new configuationbuilder if that would be useful.

[OsirisTerje]

Absolutely! Please do!

[OsirisTerje]

I also noted now, that I have been a bit sloppy here, I have upgraded and added the TestAdadpter in a separate branch, and forgot to push it up and raise a PR for it. Shame on me :-|
That also makes sense out of your comments above, so my apologies for that.
I'll push up now and raise PR, and if you @ravensorb can add the fixes for the netcore, it would be awesome!

[jilani-blend]

My App.Config file is not readable in Test Project. it works fine in the simple class library.

[OsirisTerje]

Repro please