Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add featureflag to enable/disable pre-filtering #651

Closed
OsirisTerje opened this issue Aug 28, 2019 · 2 comments · Fixed by #652
Closed

Add featureflag to enable/disable pre-filtering #651

OsirisTerje opened this issue Aug 28, 2019 · 2 comments · Fixed by #652
Assignees
Milestone

Comments

@OsirisTerje
Copy link
Member

OsirisTerje commented Aug 28, 2019

We have issues in some cases with pre-filtering, ref #648, #649, #650.

In order to avoid this, we'll add a feature flag to the runsettings file, which will be default off. You will then have to opt-in to get the performance boost.

In short what is affected:

  • Any version of NUnit below 3.11.0
  • Any test assemblies using SetupFixture
  • TestCaseData using SetName instead of SetArgDisplayNames.

The SetupFixture has to be fixed in the framework, See nunit/nunit#3356 , and when this is fixed we can consider moving pre-filtering option to default on.

Information on enabling it, see https://github.com/nunit/docs/wiki/Tips-And-Tricks#PreFilter

@OsirisTerje
Copy link
Member Author

Pre-release here: There is now a beta version of the fix in https://www.myget.org/feed/nunit/package/nuget/NUnit3TestAdapter/3.15.1-dev-01134 . Would appreciate if you checked it.

@OsirisTerje
Copy link
Member Author

3.15.1 hotfix released now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant