Fixed the compilation with xbuild #34
Conversation
Mailaender
commented
Dec 21, 2014
Mailaender
commented
fix CSC: error CS2001: Source file could not be found
|
Successfully fixed https://build.opensuse.org/request/show/266053 |
|
We can't accept this patch, which merely deletes some of the critical NUnit tests. I see from the link that your opensuse build is failing because those files are not found. They are present in the NUnit build and the correct way to fix your problem would be to get those files into your own build. How did you pull source to create this build? |
|
These files are also missing from your repository. Have a look at https://github.com/nunit/nunitv2/tree/master/src/NUnitFramework/framework/Constraints before closing this prematurely. I downloaded the source code from https://github.com/nunit/nunitv2/releases using the ZIP you yourself created. |
|
That's the wrong place in the tree. See https://github.com/nunit/nunitv2/tree/master/src/NUnitFramework/tests/Constraints However, you are correct that the source zip created by our script is missing those files. If you use the zip created by GitHub, you'll find it's correct. I'll either fix or remove our own source zip. Since GitHub creates one automatically, ours is actually redundant. Sorry for the inconvenience. |
|
Further follow-up regarding closing this: if you had filed an bug, I would not have closed it so quickly. But this is a PR that calls for dropping a bunch of our tests. I closed it because I didn't want to apply it, or for anyone else to apply it, but that wasn't meant to imply your problem isn't real. |
|
Updated https://build.opensuse.org/request/show/266134 instead. |
