Prepare for 3.7 release #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisMaddock
commented
Nov 16, 2017
| @@ -1,4 +1,3 @@ | |||
| version: 3.5.{build} | |||
There was a problem hiding this comment.
This was inconsistent with the rest of the versions, and as far as I can see, overridden by cake anyway? Maybe I missed something.
jnm2
reviewed
Nov 16, 2017
| @@ -10,7 +10,7 @@ | |||
| [assembly: AssemblyConfiguration("")] | |||
| [assembly: AssemblyCompany("")] | |||
| [assembly: AssemblyProduct("tests")] | |||
| [assembly: AssemblyCopyright("Copyright © 2016")] | |||
| [assembly: AssemblyCopyright("Copyright © 2017")] | |||
There was a problem hiding this comment.
I'm in favor of deleting AssemblyInfo.cs from all test projects since binaries aren't going anywhere. Either way.
There was a problem hiding this comment.
I think that's probably a good plan - but I don't like touching anything with copyrights on! 😆 I figure we'll probably update these all more generally for .NET Foundation pretty soon, so I'll leave as is for now. Thanks for looking things over!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions etc for a release. Would appreciate someone checking if I've missed anything.