Refactor ginkgo handler #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup the linter code by moving the ginkgo related logic (check for focus containers, and avoid test polution check), to the ginkgo linter package, in order to get cleaner main linter code.
In gomega expression, the current code knows how to skip the helper method like `WithOffset()` and get to the actual method (e.g. `Expect`). The problem is that this logic is done by comparing to a static list of method names. If a new method will be added, we'll have to add it to the list each time. This commit fixes the issue by skiping any non-actual method. Also, move things around for better oerdering.
Pull Request Test Coverage Report for Build 11663392035Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor: move ginkgo containers logic to the handler
Cleanup the linter code by moving the ginkgo related logic (check for focus containers, and avoid test polution check), to the ginkgo linter package, in order to get cleaner main linter code.
A better way to find the actual expression
In gomega expression, the current code knows how to skip the helper method like
WithOffset()and get to the actual method (e.g.Expect).The problem is that this logic is done by comparing to a static list of method names. If a new method will be added, we'll have to add it to the list each time.
This PR fixes the issue by skipping any non-actual method.
Also, move things around for better ordering.